dlmarion commented on code in PR #5939:
URL: https://github.com/apache/accumulo/pull/5939#discussion_r2388796584
##########
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/ZooReservation.java:
##########
@@ -76,7 +77,9 @@ public static void release(ZooReaderWriter zk, String path,
FateId fateId)
+ " with data mismatch " + fateId + " " + zooDataStr);
}
- zk.recursiveDelete(path, NodeMissingPolicy.SKIP);
+ // Only delete the node if the version is the same. It should be the same
as this holds the
+ // reservation, so for it to change at this point would probably indicate
a bug.
+ zk.deleteStrict(path, stat.getVersion());
Review Comment:
It looks like this could throw one of `KeeperException.NoNode`,
`KeeperException.BadVersion`, or `KeeperException.NotEmpty`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
