kevinrr888 commented on code in PR #28: URL: https://github.com/apache/accumulo-classloaders/pull/28#discussion_r2408600333
########## modules/vfs-class-loader/src/main/java/org/apache/accumulo/classloader/vfs/HDFSContextClassLoaderFactory.java: ########## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.classloader.vfs; + +import java.io.IOException; +import java.net.URL; +import java.net.URLClassLoader; +import java.nio.file.Files; +import java.util.List; + +import org.apache.accumulo.core.spi.common.ContextClassLoaderFactory; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.google.common.annotations.VisibleForTesting; +import com.google.common.cache.Cache; +import com.google.common.cache.CacheBuilder; +import com.google.gson.Gson; + +/** + * A {@link ContextClassLoaderFactory} implementation which uses a {@link URLClassLoader} per + * defined context. To use this class, need to set the Accumulo configuration property + * <b>general.context.class.loader.factory</b> to the fully qualified name of this class. <br> + * <br> + * Configuration of this class is done by having a base directory in HDFS which stores context + * directories (e.g., hdfs://test:1234/contexts could be the base directory) and where the children + * are specific contexts (e.g., contextA, contextB). To set the HDFS file system for this class, use + * {@link HDFSContextClassLoaderFactory#setHDFSFileSystem(FileSystem)}. The "contexts" directory Review Comment: Addressed in 7dce18cf535d7d92c4fc0c29b8407967cb9a7e94: no longer expect methods other than init and getClassLoader to be called -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
