ddanielr commented on code in PR #5980:
URL: https://github.com/apache/accumulo/pull/5980#discussion_r2543303585
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -1065,10 +1065,14 @@ private void handleDeadTablets(TabletLists tLists,
WalStateManager wals)
var deadLogs = tLists.logsForDeadServers;
if (!deadTablets.isEmpty()) {
- int maxServersToShow = min(deadTablets.size(), 100);
- Manager.log.debug("{} assigned to dead servers: {}...",
deadTablets.size(),
- deadTablets.subList(0, maxServersToShow));
- Manager.log.debug("logs for dead servers: {}", deadLogs);
+ Manager.log.debug("[{}] {} tablets assigned to dead servers",
store.name(),
+ deadTablets.size());
+ if (Manager.log.isTraceEnabled()) {
+ deadLogs.forEach((server, logs) -> Manager.log.trace("[{}] dead
server: {} logs: {}",
Review Comment:
This message format could probably be improved.
The original message just logged the entire map contents into the same line
so separating this into separate lines is a massive readability improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
