keith-turner commented on issue #88:
URL: https://github.com/apache/accumulo-access/issues/88#issuecomment-3571515263
> I'm not sure what the intended behavior is here, should the specification
or the code be updated to match the other?
Good find, we do need to fix this one way or another.
We would like access expression to be human readable. The current code was
created to be compatible with the code in Accumulo which accepts any byte
between the quotes (and therefore may not be human readable). The ABNF was
created w/ the goal of being human readable, but the impl does not currently
match the spec. Also looking back uncertain if the ABNF definition of UTF8 is
correct, we may have copied it from somewhere w/o validating.
We could potentially do the following to work towards achieving this goal.
1. Update the specification to define the relaxed and strict modes of
operation and the reason they exist. The relaxed parsing mode would accept any
byte between quotes and be compatible w/ existing Accumulo code. The strict
parsing mode would only accept UTF8 between quotes and must error when anything
else is seen.
2. Double check if the existing ABNF definition of UTF8 is correct.
3. Update the java code to support strict and relaxed parsing modes.
Going to mark this as a blocker, this should be fixed before 1.0 is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
