ddanielr commented on code in PR #5989: URL: https://github.com/apache/accumulo/pull/5989#discussion_r2557800617
########## server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/CoordinatorSummaryLogger.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.coordinator; + +import java.util.HashMap; +import java.util.Map; +import java.util.TreeMap; +import java.util.TreeSet; +import java.util.concurrent.atomic.AtomicLong; + +import org.apache.accumulo.core.data.TableId; +import org.apache.accumulo.core.dataImpl.KeyExtent; +import org.apache.accumulo.core.metadata.TServerInstance; +import org.apache.accumulo.server.ServerContext; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.github.benmanes.caffeine.cache.Cache; + +public class CoordinatorSummaryLogger { + private static final Logger LOG = LoggerFactory.getLogger(CoordinatorSummaryLogger.class); + + private static final TreeMap<Short,TreeSet<TServerInstance>> EMPTY = new TreeMap<>(); + private final ServerContext ctx; + private final Cache<String,Integer> compactorCounts; + + public CoordinatorSummaryLogger(ServerContext ctx, Cache<String,Integer> compactorCounts) { + this.ctx = ctx; + this.compactorCounts = compactorCounts; + } + + public void logSummary() { + + final Map<TableId,String> tableMap = ctx.getTableIdToNameMap(); + final Map<String,AtomicLong> perQueueRunningCount = new HashMap<>(); + final Map<String,AtomicLong> perTableRunningCount = new HashMap<>(); + + CompactionCoordinator.RUNNING_CACHE.values().forEach(rc -> { + TableId tid = KeyExtent.fromThrift(rc.getJob().getExtent()).tableId(); + String tableName = tableMap.getOrDefault(tid, "Unmapped table id: " + tid.canonical()); Review Comment: Is an `Unmapped table id` ever going to be something other than a deleted table? Ran a test with this and was able to show that a long running compaction can persist past a table deletion action. ``` 2025-11-24T21:18:35,555 104 [manager.EventCoordinator] INFO : Created table ExternalCompaction_1_IT_testGetActiveCompactions0 2025-11-24T21:19:35,222 37 [coordinator.CoordinatorSummaryLogger] INFO : Queue DCQ8: compactors: 1, queued majc (minimum, possibly higher): 1, running majc: 1 2025-11-24T21:19:35,222 37 [coordinator.CoordinatorSummaryLogger] INFO : Running compactions for table ExternalCompaction_1_IT_testGetActiveCompactions0: 1 2025-11-24T21:19:35,329 180 [fate.Fate] INFO : Seeding FATE[1f4521d130f4a032] TABLE_DELETE Delete table ExternalCompaction_1_IT_testGetActiveCompactions0(8) 2025-11-24T21:19:36,224 39 [coordinator.CoordinatorSummaryLogger] INFO : Queue DCQ8: compactors: 1, queued majc (minimum, possibly higher): 0, running majc: 1 2025-11-24T21:19:36,224 39 [coordinator.CoordinatorSummaryLogger] INFO : Running compactions for table Unmapped table id: 8: 1 2025-11-24T21:20:10,235 38 [coordinator.CoordinatorSummaryLogger] INFO : Queue DCQ8: compactors: 1, queued majc (minimum, possibly higher): 0, running majc: 1 2025-11-24T21:20:10,235 38 [coordinator.CoordinatorSummaryLogger] INFO : Running compactions for table Unmapped table id: 8: 1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
