dlmarion commented on code in PR #5966:
URL: https://github.com/apache/accumulo/pull/5966#discussion_r2560446293
##########
assemble/bin/accumulo:
##########
@@ -86,7 +86,18 @@ function main() {
JAVA=("${ACCUMULO_JAVA_PREFIX[@]}" "$JAVA")
fi
- exec "${JAVA[@]}" "${JAVA_OPTS[@]}" org.apache.accumulo.start.Main "$@"
+ # Allow users to supply extra Accumulo arguments via ACCUMULO_MAIN_ARGS
+ if ! declare -p ACCUMULO_MAIN_ARGS &>/dev/null; then
+ ACCUMULO_MAIN_ARGS=()
+ else
+ declare_output=$(declare -p ACCUMULO_MAIN_ARGS 2>/dev/null)
+ if [[ $declare_output != declare\ -a* ]]; then
+ ACCUMULO_MAIN_ARGS_RAW=${ACCUMULO_MAIN_ARGS[*]}
+ read -r -a ACCUMULO_MAIN_ARGS <<<"${ACCUMULO_MAIN_ARGS_RAW}"
+ fi
+ fi
Review Comment:
Regarding point # 3, it would be useful to have an example of how the
includes would work. If you understand commons-configuration and how it works,
then it's obvious. If you don't, then it's not obvious and the user is unlikely
to even think about it as a viable option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
