DomGarguilo commented on code in PR #5990:
URL: https://github.com/apache/accumulo/pull/5990#discussion_r2578547684
##########
core/src/main/java/org/apache/accumulo/core/client/admin/NewTableConfiguration.java:
##########
@@ -312,6 +347,7 @@ public NewTableConfiguration attachIterator(IteratorSetting
setting,
// verify that the iteratorProps assigned and the properties do not
share any keys.
checkDisjoint(properties, iteratorProps, "iterator");
}
+ iteratorSettings.put(setting, scopes);
Review Comment:
I think there may be a bug here. I think this will just replace any existing
scopes in the map that have the same setting as key when attachIterator is
called multiple times with a matching key. I think we need to merge the
incoming `scopes` with the existing scopes so that when things are checked in
checkIteratorConflictsWithDefaults(), it has everything instead of just the
last one set to check against.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
