dlmarion commented on code in PR #33:
URL:
https://github.com/apache/accumulo-classloaders/pull/33#discussion_r2586229938
##########
modules/local-caching-classloader/src/test/java/org/apache/accumulo/classloader/lcc/LocalCachingContextClassLoaderFactoryTest.java:
##########
@@ -224,10 +224,8 @@ public void testInitialInvalidJson() throws Exception {
def.toJson().substring(0, 4));
final URL invalidDefUrl = new URL(fs.getUri().toString() +
invalid.toUri().toString());
- ContextClassLoaderException ex =
assertThrows(ContextClassLoaderException.class,
+ assertThrows(ContextClassLoaderException.class,
Review Comment:
The error changed when I set GSON to use pretty printing. Not sure the exact
error message is a concern here.
##########
pom.xml:
##########
@@ -411,7 +411,7 @@ under the License.
<reactorModuleConvergence />
<banDuplicatePomDependencyVersions />
<dependencyConvergence />
- <banDynamicVersions />
+ <!-- <banDynamicVersions />-->
Review Comment:
Can revert this when 2.1.5 is released and the version changed above.
##########
modules/local-caching-classloader/src/test/java/org/apache/accumulo/classloader/lcc/MiniAccumuloClusterClassLoaderFactoryTest.java:
##########
@@ -75,14 +83,23 @@
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.sun.tools.attach.VirtualMachine;
+import com.sun.tools.attach.VirtualMachineDescriptor;
public class MiniAccumuloClusterClassLoaderFactoryTest extends
SharedMiniClusterBase {
+ private static final Logger LOG =
+ LoggerFactory.getLogger(MiniAccumuloClusterClassLoaderFactoryTest.class);
+
private static class TestMACConfiguration implements
MiniClusterConfigurationCallback {
@Override
public void configureMiniCluster(MiniAccumuloConfigImpl cfg,
org.apache.hadoop.conf.Configuration coreSite) {
+ cfg.removeJvmOption("-XX:+PerfDisableSharedMem");
Review Comment:
This requires https://github.com/apache/accumulo/pull/5999 to be merged.
This JVM option was not allowing the test to attach to the locally running
Accumulo JVM processes. Additionally, I think this is what causes `jps` not to
report the processes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
