dlmarion commented on code in PR #5999:
URL: https://github.com/apache/accumulo/pull/5999#discussion_r2586501812
##########
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java:
##########
@@ -356,14 +357,13 @@ private ProcessInfo _exec(Class<?> clazz, List<String>
extraJvmOpts, String... a
var hardcodedArgs = Stream.of(
"-Dapple.awt.UIElement=true",
Review Comment:
I got rid of the rest of the hardcoded args in 348d747. I added them to the
system properties map in the Config class.
##########
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloConfigImpl.java:
##########
@@ -681,6 +687,38 @@ public Map<String,String> getSystemProperties() {
return new HashMap<>(systemProperties);
}
+ /**
+ * Add a JVM option to the spawned JVM processes. The default set of JVM
options contains
+ * '-XX:+PerfDisableSharedMem' and '-XX:+AlwaysPreTouch'
+ *
+ * @param option JVM option
+ * @since 2.1.5
+ */
+ public void addJvmOption(String option) {
+ this.jvmOptions.add(option);
+ }
+
+ /**
+ * Remove an option from the set of JVM options
+ *
+ * @param option JVM option
+ * @return true if removed, false if not removed
+ * @since 2.1.5
+ */
+ public boolean removeJvmOption(String option) {
Review Comment:
Updated javadoc in 348d747.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
