keith-turner commented on code in PR #6006:
URL: https://github.com/apache/accumulo/pull/6006#discussion_r2592909194
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -440,14 +440,21 @@ private void removeOldTemporaryFiles(
for (FileStatus tmp : volume.getFileSystem().globStatus(new
Path(dirUri, "*_tmp"))) {
if (extCompactionFiles.contains(tmp.getPath())) {
+ log.debug("Not removing compaction temp file {}, it's in use by an
external compaction",
+ tmp.getPath());
continue;
}
try {
- log.debug("Removing old temp file {}", tmp.getPath());
- volume.getFileSystem().delete(tmp.getPath(), false);
+ if (volume.getFileSystem().delete(tmp.getPath(), false)) {
+ log.debug("Removed old temp file {}", tmp.getPath());
+ } else {
+ log.debug(
Review Comment:
could change this to error to be consistent w/ the other message about not
being able to remove the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
