DomGarguilo commented on code in PR #6032:
URL: https://github.com/apache/accumulo/pull/6032#discussion_r2635653487
##########
test/src/main/java/org/apache/accumulo/test/fate/FateITBase.java:
##########
@@ -591,7 +591,13 @@ protected void
testShutdownDoesNotFailTx(FateStore<TestEnv> store, ServerContext
fate.seedTransaction(TEST_FATE_OP, txid, new
TestRepo("testShutdownDoesNotFailTx"), true,
"Test Op");
- assertEquals(TStatus.SUBMITTED, getTxStatus(sctx, txid));
+ // The Fate operation could be in a SUBMITTED state if the
+ // Fate transaction runner thread has not picked it up yet.
+ // If the thread has picked it up, then it will be in an
+ // IN_PROGRESS state, but will be waiting on the finishCall
+ // latch to be called to continue.
+ assertTrue(TStatus.SUBMITTED == getTxStatus(sctx, txid)
+ || TStatus.IN_PROGRESS == getTxStatus(sctx, txid));
Review Comment:
Could we do a `Wait.for(()->TStatus.IN_PROGRESS == getTxStatus(sctx, txid))`
or is it not guaranteed to reach IN_PROGRESS?
Also were you seeing test failures that prompted this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
