keith-turner commented on code in PR #96:
URL: https://github.com/apache/accumulo-access/pull/96#discussion_r2677816654
##########
core/src/main/java/org/apache/accumulo/access/impl/AccessEvaluatorImpl.java:
##########
@@ -30,42 +29,56 @@
import org.apache.accumulo.access.AccessEvaluator;
import org.apache.accumulo.access.AccessExpression;
+import org.apache.accumulo.access.AuthorizationValidator;
import org.apache.accumulo.access.Authorizations;
import org.apache.accumulo.access.InvalidAccessExpressionException;
+import org.apache.accumulo.access.InvalidAuthorizationException;
public final class AccessEvaluatorImpl implements AccessEvaluator {
- private final Predicate<BytesWrapper> authorizedPredicate;
+ private final Predicate<CharSequence> authorizedPredicate;
+ // TODO set
+ private final AuthorizationValidator authorizationValidator;
/**
* Create an AccessEvaluatorImpl using an Authorizer object
*/
- public AccessEvaluatorImpl(Authorizer authorizationChecker) {
- this.authorizedPredicate = auth ->
authorizationChecker.isAuthorized(unescape(auth));
+ public AccessEvaluatorImpl(Authorizer authorizationChecker,
+ AuthorizationValidator authorizationValidator) {
+ this.authorizedPredicate = auth ->
authorizationChecker.isAuthorized(auth.toString());
+ this.authorizationValidator = authorizationValidator;
Review Comment:
It should not be, added test and checks in
6752d657d5a4e926784150575779e04b73edb8f5. The checks for null are in the API
entry point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
