ddanielr commented on code in PR #6049:
URL: https://github.com/apache/accumulo/pull/6049#discussion_r2684078944
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -450,6 +450,10 @@ public enum Property {
"The number of threads used to run fault-tolerant executions (FATE)."
+ " These are primarily table operations like merge.",
"1.4.3"),
+ MANAGER_MAX_TSERVER_HALTS("manager.max.tservers.halts", "0",
PropertyType.COUNT,
Review Comment:
Talked this over with @ctubbsii and settled on on using a time-based max
timeout for halt requests.
The number of attempts is already based on the max rpc request timeout and
number of failed communication attempts to the tserver.
If the tserver is able to successfully return information after a halt is
called on it, then this code path isn't followed.
What is unclear is if connections can still be attempting to a tserver that
is in the process of halting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
