ctubbsii commented on code in PR #40:
URL:
https://github.com/apache/accumulo-classloaders/pull/40#discussion_r2691736071
##########
modules/local-caching-classloader/src/main/java/org/apache/accumulo/classloader/lcc/util/DeduplicationCache.java:
##########
@@ -51,6 +69,7 @@ public VALUE computeIfAbsent(final KEY key, final
Supplier<PARAMS> params) {
}
public boolean anyMatch(final Predicate<KEY> keyPredicate) {
+ canonicalWeakValuesCache.cleanUp();
Review Comment:
We don't need a scheduler on the weak values cache, because the extra
internal WeakReferences won't matter. They won't point to anything. The
scheduler is probably more busy work than just leaving the unused null
references alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
