dlmarion commented on code in PR #33: URL: https://github.com/apache/accumulo-classloaders/pull/33#discussion_r2695619768
########## modules/local-caching-classloader/README.md: ########## @@ -122,16 +122,18 @@ download, and any modification will likely cause unexpected behavior. ## Creating a ContextDefinition file Users may take advantage of the `ContextDefinition.create(int,URL[])` method to -construct a `ContextDefinition` object. This will calculate the checksums of -the classpath elements. `ContextDefinition.toJson()` can be used to serialize -the `ContextDefinition` to a `String` to store in a file. +construct a `ContextDefinition` object, programmatically. This will calculate +the checksums of the classpath elements. `ContextDefinition.toJson()` can be +used to serialize the `ContextDefinition` to a `String` to store in a file. -Alternatively, if the local-caching-classloader jar is built and placed into the $ACCUMULO_HOME/lib directory, then -the `$ACCUMULO_HOME/bin/accumulo create-context-definition` command can be used to create the -ContextDefinition json. The command takes 3 arguments: the name of the context, the monitor interval, -and a list of file URLs. The resulting json is printed to stdout and can be redirected to a file. Users -may take advantage of the `ContextDefinition.create` and `ContextDefinition.toJson` methods to -construct a ContextDefinition object if they wish to do this programmatically. +Alternatively, if this library's jar is built and placed onto Accumulo's +`CLASSPATH`, then one can run `bin/accumulo create-context-definition` to +create the ContextDefinition json file using the command-line. The resulting +json is printed to stdout and can be redirected to a file. The command takes +two arguments: + +1. the monitor interval, in seconds (e.g. `-i 300`), and +2. a list of file URLs (e.g. `-f hdfs://host:port/path/to/one.jar http://host/path/to/two.jar`) Review Comment: Fixed in 4258435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
