keith-turner commented on PR #48: URL: https://github.com/apache/accumulo-classloaders/pull/48#issuecomment-3761870614
>> In https://github.com/apache/accumulo-classloaders/pull/49 I removed all calls to URL.setURLStreamHandlerFactory in the test and the test are passing, so that indicates that change will probably also work in Accumulo w/ HDFS. > >I commented on that. We should not do that. I explained why on that PR. I think #49 is cleaner because it avoids registering JVM wide resources (which could cause code outside the classloader plugin to change behavior). I really like the locality. In the current code FileResolver is where the download happens, if its happy w/ the URL/URI then things are fine. Looking at the java code that converts URIs to URLs the main thing it checks is if the URI has a scheme which #49 adds a check for in FileResolver. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
