kevinrr888 commented on code in PR #6040:
URL: https://github.com/apache/accumulo/pull/6040#discussion_r2714534380
##########
core/src/main/java/org/apache/accumulo/core/iteratorsImpl/IteratorConfigUtil.java:
##########
@@ -57,6 +66,19 @@ public class IteratorConfigUtil {
public static final Comparator<IterInfo> ITER_INFO_COMPARATOR =
Comparator.comparingInt(IterInfo::getPriority);
+ private static final String ITERATOR_PROP_REGEX =
+ ("^" + Property.TABLE_ITERATOR_PREFIX.getKey() + "(" +
Arrays.stream(IteratorScope.values())
Review Comment:
What I could do is:
1) if they don't match the regex, but they do begin with the table iterator
prefix `table.iterator.` I can throw an exception.
This will add new validation/new cases where an exception will be thrown
(for example, previously only a couple things were validated about the iterator
property like the string in the expected spot for priority had to be an int,
and the property value had to be length 2 when split by ",").
If we go with (1), user code could now throw exceptions where they weren't
before, but this is probably fine as their code is broken anyways
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
