ddanielr commented on PR #6073:
URL: https://github.com/apache/accumulo/pull/6073#issuecomment-3799941028
Tested this locally and scan servers now prune correctly with the group
keyword working correctly.
While testing I also noticed that the GC lock was always being marked for
pruning.
Went back to 2.1.4 and that behavior was present before this PR.
Looks like the GC lock format is different than the manager or monitor lock
so the hostPortPredicate test never passes.
The gc lock format is `GC_CLIENT=localhost:9998` vs the manager's
`localhost:9999`.
Assuming we don't want to change the lock format, the fix is just adding
another specific lock type deletion method that does the following check:
```
var lockData = ServiceLock.getLockData(zoo.getZooKeeper(),
ServiceLock.path(path));
if (lockData != null) {
String lockContent = new String(lockData, UTF_8);
String[] parts = lockContent.split("=");
if (parts.length == 2 &&
hostPortPredicate.test(HostAndPort.fromString(parts[1]))) {
zapDirectory(zoo, path, ops);
}
}
```
I'll create an issue ticket for that work. I think this PR is good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
