kevinrr888 commented on code in PR #6072:
URL: https://github.com/apache/accumulo/pull/6072#discussion_r2729410915
##########
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java:
##########
@@ -789,7 +789,18 @@ List<ProcessReference> references(Process... procs) {
public Map<ServerType,Collection<ProcessReference>> getProcesses() {
Map<ServerType,Collection<ProcessReference>> result = new HashMap<>();
MiniAccumuloClusterControl control = getClusterControl();
- result.put(ServerType.MANAGER, references(control.managerProcess));
+ if (control.managerProcess != null) {
+ result.put(ServerType.MANAGER, references(control.managerProcess));
+ }
+ if (control.coordinatorProcess != null) {
+ result.put(ServerType.COMPACTION_COORDINATOR,
references(control.coordinatorProcess));
+ }
+ result.put(ServerType.COMPACTOR,
+ references(control.compactorProcesses.toArray(new Process[0])));
+ result.put(ServerType.SCAN_SERVER,
+ references(control.scanServerProcesses.toArray(new Process[0])));
+ result.put(ServerType.TABLET_SERVER,
+ references(control.tabletServerProcesses.toArray(new Process[0])));
Review Comment:
Could make this more future-proof by iterating through all `ServerType`s and
using a switch statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
