DomGarguilo commented on code in PR #6080:
URL: https://github.com/apache/accumulo/pull/6080#discussion_r2737650079
##########
core/src/main/java/org/apache/accumulo/core/metrics/Metric.java:
##########
@@ -303,7 +303,13 @@ public enum Metric {
MetricDocSection.MANAGER),
MANAGER_USER_TGW_ERRORS("accumulo.tabletmgmt.user.errors", MetricType.GAUGE,
"Error count encountered by the TabletGroupWatcher for the USER data
level.",
- MetricDocSection.MANAGER);
+ MetricDocSection.MANAGER),
+ MANAGER_GOAL_CLEAN_STOP("accumulo.manager.goal.clean.stop", MetricType.GAUGE,
+ "Value of 1 indicates clean stop goal, 0 otherwise",
MetricDocSection.MANAGER),
+ MANAGER_GOAL_NORMAL_MODE("accumulo.manager.goal.normal", MetricType.GAUGE,
+ "Value of 1 indicates normal mode goal, 0 otherwise",
MetricDocSection.MANAGER),
+ MANAGER_GOAL_SAFE_MODE("accumulo.manager.goal.safe.mode", MetricType.GAUGE,
+ "Value of 1 indicates safe mode goal, 0 otherwise",
MetricDocSection.MANAGER);
Review Comment:
Would it make more sense to just have a single gauge for this?
```suggestion
MANAGER_GOAL_STATE("accumulo.manager.goal.state", MetricType.GAUGE,
"Manager goal state: -1=unknown, 0=CLEAN_STOP, 1=SAFE_MODE, 2=NORMAL.",
MetricDocSection.MANAGER);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
