keith-turner commented on code in PR #6025:
URL: https://github.com/apache/accumulo/pull/6025#discussion_r2737624744
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java:
##########
@@ -531,6 +533,7 @@ public synchronized long getNumEntries() {
private final Set<MemoryIterator> activeIters =
Collections.synchronizedSet(new HashSet<>());
+ @NotThreadSafe
class MemoryDataSource implements DataSource {
Review Comment:
This method has a synchronized method and it trying handle the case of an
iterator being concurrently switched from in memory data to a file. Looking at
the bigger picture there is a lot of locking going on around this with syncs on
differnt objects. I would like to open a follow on issue to analyze this
further and see if simplifications can be made and check it for correctness.
What is the best thing to do in the PR if we want a follow on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
