ctubbsii commented on PR #58: URL: https://github.com/apache/accumulo-classloaders/pull/58#issuecomment-3838344921
This would close #44 and #45 . There is a small race condition that is detected by handling a NoSuchFileException when creating hard-links. This might be avoidable, but it's not in a great spot for retrying. This could be improved upon later. I would like feedback on the file naming conventions and directory layout. I tried to make it relatively simple, but everything looks like a mess with checksums in the filenames. That part can't be helped. I think some of the test changes I ripped out of the mini test when I removed the JMX stuff could be replaced with checks for the existence of the temporary directories in the `working` directory. Similar checks could be added to other tests. It's hard to verify automatic cleanup of the `working` directory when using the DeduplicationCache, because that has a minimum lifetime of 24h, but I think it could be possible to check that if using the `LccUtils.createClassLoader` method directly in the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
