kevinrr888 commented on issue #6061:
URL: https://github.com/apache/accumulo/issues/6061#issuecomment-3849619368

   Due to my limited time on the project going forward, I am unassigning myself 
from this ticket. I have looked into all services to identify problematic 
methods, and listed them here for someone else to use as a starting point.
   
   Key:
   
   1 = Handler methods that declare "throws TException". The method signatures 
of these need to be changed to only declare "throws" for the TException 
subclasses that are actually thrown. May also need to change the thrift file in 
which the service is defined to declare "throws" for the exception as well. If 
the handler impl declares "throws SomeTException", the method in the thrift 
file must also declare "throws SomeTException".
   
   2 = Handler methods that declare "throws" for any TException subclass not 
defined as "throws" in the IDL. For these problematic methods, need to update 
the method in the thrift file to declare "throws" for any TException subclass 
that is declared as "throws" in the handler method impl.
   
   Problematic services and methods:
   
   ```
   - manager.thrift
        - FateService
                - No issues
        - ManagerClientService
                - removeTableProperty: 2
                - modifyNamespaceProperties: 1
                - removeNamespaceProperty: 2
                - tabletServerStopping: 1
                - setSystemProperty: 1
                - modifySystemProperties: 1
                - reportSplitExtent: 2
                - reportTabletStatus: 2
                - getDelegationToken: 1
                - drainReplicationTable: 1
   
   - test.thrift (test code, so not important but considered regardless)
        - SimpleThriftService
                - echoFail: 1
                - onewayFail: 1
                - echoPassVoid: 1
   
   - replication.thrift
        - ReplicationCoordinator
                - getServicerAddress: 1
        - ReplicationServicer
                - replicateLog: 1
   
   - compaction-coordinator.thrift
        - CompactionCoordinatorService
                - compactionCompleted: 2
                - getCompactionJob: 2
                - updateCompactionStatus: 2
                - compactionFailed: 2
                - getRunningCompactions: 2
                - getCompletedCompactions: 2
                - cancel: 1
        - CompactorService
                - getRunningCompaction: 1
                - getRunningCompactionId: 1
                - getActiveCompactions: 1
                - cancel: 1
   
   trace.thrift
        - No services
        
   security.thrift
        - No services
        
   process.thrift
        - ServerProcessService
                - No issues
   
   client.thrift
        - ClientService
                - bulkImportFiles: 1
                - getDiskUsage: 1
                - grantTablePermission: 1
                - revokeTablePermission: 1
                - getConfiguration: 1
                - getTableConfiguration: 1
                - getTableProperties: 1
                - getVersionedTableProperties: 1
                - getNamespaceConfiguration: 1
                - getNamespaceProperties: 1
                - getVersionedNamespaceProperties: 1
                - checkClass: 1
                - checkTableClass: 1
                - checkNamespaceClass: 1
        - ThriftTest (test code, so not important but considered regardless)
                - success: 1
                - fails: 1
                - throwsError: 1
   
   tabletserver.thrift
        - TabletScanClientService
                - startScan impl in ScanServer: 1
                - continueScan impl in ScanServer: 1
                - closeScan impl in ScanServer: 1
                - startMultiScan impl in ScanServer: 1
                - continueMultiScan impl in ScanServer: 1
                - closeMultiScan impl in ScanServer: 1
                - getActiveScans impl in ScanServer: 1
                - getActiveScans impl in ThriftScanClientHandler: 1
        - TabletClientService
                - cancelUpdate: 1
                - startConditionalUpdate: 1
                - conditionalUpdate: 1
                - loadFiles: 2
                - loadFilesV2: 2
                - getActiveCompactions: 1
                - startGetSummaries: 1
                - startGetSummariesForPartition: 1
                - startGetSummariesFromFiles: 1
                - contiuneGetSummaries: 1
                - getCompactionQueueInfo: 1
                - reserveCompactionJob: 1
                - compactionJobFinished: 1
                - compactionJobFailed: 1
                
   gc.thrift
        - GCMonitorService
                - No issues
   
   master.thrift
        - No services
   
   data.thrift
        - No services
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to