dlmarion commented on code in PR #69: URL: https://github.com/apache/accumulo-classloaders/pull/69#discussion_r2784085337
########## modules/caching-class-loader/src/main/java/org/apache/accumulo/classloader/ccl/cli/Help.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.classloader.ccl.cli; + +import java.util.function.Consumer; + +import com.beust.jcommander.JCommander; +import com.beust.jcommander.Parameter; +import com.beust.jcommander.ParameterException; + +class Help { + @Parameter(names = {"-h", "-?", "--help", "-help"}, help = true) + public boolean help = false; + + void parseArgs(Consumer<JCommander> jcConsumer, String programName, String[] args, + Object... others) { + JCommander commander = new JCommander(); + jcConsumer.accept(commander); + commander.addObject(this); + for (Object other : others) { + commander.addObject(other); + } + commander.setProgramName(programName); + try { + commander.parse(args); + } catch (ParameterException ex) { + commander.usage(); + exitWithError(ex.getMessage(), 1); + } + if (help) { + commander.usage(); + exit(0); + } + } + + void parseArgs(String programName, String[] args, Object... others) { + parseArgs(jCommander -> {}, programName, args, others); + } + + void exit(int status) { + System.exit(status); + } + + void exitWithError(String message, int status) { + System.err.println(message); + exit(status); + } Review Comment: I think these can be marked private. ########## modules/caching-class-loader/src/main/java/org/apache/accumulo/classloader/ccl/cli/InitializeCache.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.classloader.ccl.cli; + +import java.net.URL; +import java.util.ArrayList; +import java.util.List; + +import org.apache.accumulo.classloader.ccl.CachingClassLoaderFactory; +import org.apache.accumulo.classloader.ccl.LocalStore; +import org.apache.accumulo.classloader.ccl.manifest.Manifest; +import org.apache.accumulo.start.spi.KeywordExecutable; + +import com.beust.jcommander.Parameter; +import com.google.auto.service.AutoService; + +@AutoService(KeywordExecutable.class) +public class InitializeCache implements KeywordExecutable { + + static class Opts extends Help { + @Parameter(names = {"-d", "--directory"}, required = true, + description = "the local directory to initialize and stage", arity = 1, order = 1) + String directory; + + @Parameter(names = {"-v", "--verify"}, required = false, + description = "also verify existing files if they were found already present", arity = 0, + order = 2) + boolean verify; + + @Parameter(required = false, + description = "URLs for context manifests to load (<url>[ <url>...])", arity = -1, + order = 3) + public List<String> manifests = new ArrayList<>(); + } + + public InitializeCache() {} + + @Override + public String keyword() { + return "init-classloader-cache-dir"; + } + + @Override + public String description() { + return "Initializes the specified directory for the " + + CachingClassLoaderFactory.class.getSimpleName() + + " and stages any resources for the specified context manifest locations"; + } + + @Override + public void execute(String[] args) throws Exception { + var opts = new Opts(); + opts.parseArgs(InitializeCache.class.getName(), args); + var localStore = new LocalStore(opts.directory, (a, b) -> {/* allow all */}); Review Comment: why allow all here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
