keith-turner commented on code in PR #6040:
URL: https://github.com/apache/accumulo/pull/6040#discussion_r2784954147
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/NamespaceOperationsImpl.java:
##########
@@ -215,6 +218,11 @@ private Map<String,String> tryToModifyProperties(final
String namespace,
// from here on the code is assured to always be dealing with the same map.
vProperties.setProperties(Map.copyOf(vProperties.getProperties()));
+ for (var property : vProperties.getProperties().entrySet()) {
+ IteratorConfigUtil.checkIteratorConflicts(tableOps, this, namespace,
property.getKey(),
Review Comment:
Noticed that for each namespace property that this will fetch the properties
for all tables under the namespace. That makes this check really expensive.
Rather than trying to optimize this, going to look into refactoring this to
only check the namespaces properties and not check table props.
@ctubbsii made a comment about this sort of check earlier that I agree with.
> That's not exactly practical, so we may just want to check that there
isn't a conflict at the level being modified, and rely on later checks when
setting up the iterator stack to verify that there isn't a conflict overall.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
