keith-turner commented on code in PR #6111:
URL: https://github.com/apache/accumulo/pull/6111#discussion_r2795096321
##########
core/src/main/java/org/apache/accumulo/core/iteratorsImpl/IteratorProperty.java:
##########
@@ -144,15 +144,22 @@ public static IteratorProperty parse(String property,
String value) {
check(iterPropParts.length == 4 || iterPropParts.length == 6, property,
value);
IteratorUtil.IteratorScope scope =
IteratorUtil.IteratorScope.valueOf(iterPropParts[2]);
String iterName = iterPropParts[3];
+ check(!iterName.isEmpty(), property, value);
if (iterPropParts.length == 4) {
- String[] valTokens = value.split(",");
+ String[] valTokens = value.split(",", -1);
Review Comment:
Looking at the docs for split it seems like `-1` will give empty strings
back. Is that why it was used here?
Wondering if the split on `.` a bit further up should also pass `-1` to
split.
Might be good to pull the improvements in this function to make parsing more
strict back to 2.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
