ddanielr commented on code in PR #6144:
URL: https://github.com/apache/accumulo/pull/6144#discussion_r2843094249
##########
server/compactor/src/main/java/org/apache/accumulo/compactor/ExtCEnv.java:
##########
@@ -80,6 +80,11 @@ public String getQueueName() {
this.queueName = queueName;
}
+ @Override
+ public String getThreadPrefix() {
+ return "ExtC";
Review Comment:
> Could this just be "MajC"? ExternalCompactors only run major compactors,
and these will be on the only compaction threads in the Compactor JVM.
Yeah I think that's fine. It changes less behavior in 2.1 as well.
> If external compactions are not differentiated, then maybe we could use
`CompactionEnv.getIteratorScope()` for the naming of the thread.
That sounds good. IteratorScope is also public so I'll just move the scope
check up and handle the rename inside FileCompactor
https://github.com/apache/accumulo/blob/cf57e343de77f416de10c22e0ed05ef37f433b36/core/src/main/java/org/apache/accumulo/core/iterators/IteratorUtil.java#L28-L35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
