keith-turner commented on issue #103: URL: https://github.com/apache/accumulo-access/issues/103#issuecomment-4026557250
When evaluating expression authorizations are validated, but its done outside of the tokenizer. The following code passes in a lambda to the parser that validate authorization tokens in the expression. Maybe it would be cleaner to push the validation into the Tokenizer from a code organization perspective. https://github.com/apache/accumulo-access/blob/75860105144dde9ce7fd25aba70a4b6d519f7b5a/core/src/main/java/org/apache/accumulo/access/impl/AccessEvaluatorImpl.java#L166 There are also test for validation during expression evaluation in [AuthorizationTest](https://github.com/apache/accumulo-access/blob/main/core/src/test/java/org/apache/accumulo/access/tests/AuthorizationTest.java). It test quoting and custom validation in expression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
