keith-turner commented on code in PR #102:
URL: https://github.com/apache/accumulo-access/pull/102#discussion_r2912936908
##########
modules/core/src/main/java/org/apache/accumulo/access/impl/AccessExpressionImpl.java:
##########
@@ -77,7 +77,7 @@ public static CharSequence quote(CharSequence term) {
}
public static CharSequence unquote(CharSequence term) {
- if (term.equals("\"\"") || term.isEmpty()) {
+ if (term.toString().equals("\"\"") || term.isEmpty()) {
Review Comment:
>I 'm wondering why it should care about the empty string case or the quoted
empty string case only, but not others.
I opened #104 as a follow on issue that adds test to cover these cases. It
would be nice to make the API impl more strict w/ inputs to support fail fast
behavior for these cases. Did not do any implementation changes, it could be
done as follow on or part of this, but did not want it to get lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
