ddanielr commented on PR #6219: URL: https://github.com/apache/accumulo/pull/6219#issuecomment-4135950973
> > I wanted to be a bit more careful about it in 2.1 but if you don't see a reason to keep this code around then I'll push a change to just remove the scan and volume deletion shortcut entirely. > > I support removing this optimization in general. Do share the concerns about introducing bugs in 2.1. Looked at what test we have for delete table to see if any verified the files actually eventually go away. I could not find any test that verifies this. I looked at test method names that called TableOperations.delete and for test I was not sure about based on the name I looked at the test. > > Maybe part of removing this in 2.1 is adding some more test. Want to ensure the files exists before delete and that after delete the tables file and dir eventually go away. That would cover the risk that delete table leaves files behind w/ this change. If delete does more than its supposed to (like messes w/ another table) I suspect existing test would catch that as we create/delete a lot in the test. Added additional tests in 4ed3071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
