keith-turner commented on PR #6213: URL: https://github.com/apache/accumulo/pull/6213#issuecomment-4179702437
>This looks fine but it may be better to move this new data gathering out of the memoized supplier Monitor.java and into InformationFetcher/SystemInformation. Looked into this and for now its probably best to leave the data collection in the memoized supplier. The reason is that the data collection scans the entire fate table and the results of that scan are only used by this one view. In the future if we want to derive more information from the fate table for multiple views and/or join information from the fate table with other data like metrics, then it would be good to move this into InformationFetcher. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
