dlmarion commented on PR #6364: URL: https://github.com/apache/accumulo/pull/6364#issuecomment-4440984985
Commit 412d9d2 resolves some of the issues from the prior comment. Specifically, it does the following: - Creates a MeterRegistryFactory for the MonitorMeterRegistry so it can be configured independently. - Modifies MiniAccumuloConfigImpl to disable metrics. - Modifies ITs that use metrics to fully set them up. - Fixes an issue where cache and fate metrics were being emitted when metrics were disabled. - Modifies AbstractServer.getMetrics to only emit metrics if the MonitorMeterRegistry is configured. - Removed metrics configuration from some ITs that were not using them. @ctubbsii and I had a discussion about the behavior of enabling / disabling metrics totally using the property `GENERAL_MICROMETER_ENABLED`. If this property is set to `false`, then no metrics are set up at all. There was a question as to whether this property should only apply to Accumulo related metrics. If so, then the properties `GENERAL_MICROMETER_JVM_METRICS_ENABLED` and `GENERAL_MICROMETER_LOG_METRICS` would act independently. I think it's fine to leave things as they are. If someone wants to set up the global registry using a Java Agent or Spring Boot, they can add the JVM and log metrics at that time and disable ours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
