DomGarguilo commented on code in PR #6377:
URL: https://github.com/apache/accumulo/pull/6377#discussion_r3267542114
##########
core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/CachableBlockFile.java:
##########
@@ -183,56 +183,45 @@ private BCFile.Reader getBCFile(Supplier<byte[]>
cachedMetadataSupplier) throws
BCFile.Reader reader = bcfr.get();
if (reader == null) {
- IOException ioe = null;
RateLimitedInputStream fsIn =
new RateLimitedInputStream((InputStream & Seekable)
inputSupplier.get(), readLimiter);
BCFile.Reader tmpReader = null;
byte[] serializedMetadata = cachedMetadataSupplier.get();
Review Comment:
If `cachedMetadataSupplier.get()` can throw, that should probably be moved
into the try block too. Otherwise this PR LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
