dlmarion commented on code in PR #6397:
URL: https://github.com/apache/accumulo/pull/6397#discussion_r3320413035
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/js/tservers.js:
##########
@@ -312,7 +306,17 @@ $(document).ready(function () {
return data;
}
}
- ]
+ ],
+
+ // Only show the table if there are non-empty rows
+ "drawCallback": function () {
+ if (this.api().rows().data().length === 0) {
+ $('#deadtservers_wrapper').hide();
+ }
+ else {
+ $('#deadtservers_wrapper').show();
+ }
Review Comment:
spacing seems off here
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/js/tservers.js:
##########
@@ -312,7 +306,17 @@ $(document).ready(function () {
return data;
}
}
- ]
+ ],
+
+ // Only show the table if there are non-empty rows
Review Comment:
[This
comment](https://github.com/apache/accumulo/issues/6379#issuecomment-4501967293)
suggests that maybe we should never hide the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
