DomGarguilo commented on code in PR #132:
URL: https://github.com/apache/accumulo-examples/pull/132#discussion_r3357257163
##########
docs/classpath.md:
##########
@@ -17,32 +17,16 @@ limitations under the License.
# Apache Accumulo Classpath Example
This example shows how to use per table classpaths. The example leverages a
-test jar which contains a Filter that suppresses rows containing "foo". The
-example shows copying the FooFilter.jar into HDFS and then making an Accumulo
-table reference that jar. For this example, a directory, `/user1/lib`, is
-assumed to exist in HDFS.
-
-Create `/user1/lib` in HDFS if it does not exist.
-
- hadoop fs -mkdir -p /user1/lib
-
-Execute the following command in the shell. Note that the `FooFilter.jar`
-is located within the Accumulo source distribution.
-
- $ hadoop fs -copyFromLocal
/path/to/accumulo/test/src/main/resources/org/apache/accumulo/test/FooFilter.jar
/user1/lib
-
-Execute following in Accumulo shell to setup classpath context
-
- root@uno> config -s general.vfs.context.classpath.cx1=hdfs://<namenode
host>:<namenode port>/user1/lib/[^.].*.jar
+test jar which contains a Filter that suppresses rows containing "foo".
Review Comment:
Would be good to describe the new mechanism a bit:
```suggestion
test jar which contains a Filter that suppresses rows containing "foo". The
example shows configuring a table to reference the jar using the built-in
URL-based context class loader.
```
##########
docs/classpath.md:
##########
@@ -17,32 +17,16 @@ limitations under the License.
# Apache Accumulo Classpath Example
This example shows how to use per table classpaths. The example leverages a
-test jar which contains a Filter that suppresses rows containing "foo". The
-example shows copying the FooFilter.jar into HDFS and then making an Accumulo
-table reference that jar. For this example, a directory, `/user1/lib`, is
-assumed to exist in HDFS.
-
-Create `/user1/lib` in HDFS if it does not exist.
-
- hadoop fs -mkdir -p /user1/lib
-
-Execute the following command in the shell. Note that the `FooFilter.jar`
-is located within the Accumulo source distribution.
-
- $ hadoop fs -copyFromLocal
/path/to/accumulo/test/src/main/resources/org/apache/accumulo/test/FooFilter.jar
/user1/lib
-
-Execute following in Accumulo shell to setup classpath context
-
- root@uno> config -s general.vfs.context.classpath.cx1=hdfs://<namenode
host>:<namenode port>/user1/lib/[^.].*.jar
+test jar which contains a Filter that suppresses rows containing "foo".
Create a namespace and table
root@uno> createnamespace examples
root@uno> createtable examples.nofoo
-The following command makes this table use the configured classpath context
+The following command makes this table use the configured classpath context to
`FooFilter.jar`
- root@uno examples.nofoo> config -t examples.nofoo -s
table.class.loader.context=cx1
+ root@uno examples.nofoo> config -t examples.nofoo -s
table.class.loader.context=file://<your-root-directory>/github/accumulo/test/src/main/resources/org/apache/accumulo/test/FooFilter.jar
Review Comment:
```suggestion
root@uno examples.nofoo> config -t examples.nofoo -s
table.class.loader.context=file:///path/to/accumulo/test/src/main/resources/org/apache/accumulo/test/FooFilter.jar
```
I think you were missing an extra `/` here and also we can keep the example
path how it was for clarity/consistency. (this should be updated in the other
config command below too)
##########
docs/classpath.md:
##########
Review Comment:
```suggestion
to use the jar URL as its classpath context. This fails until the table is
configured to
use the jar URL.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
