ctubbsii commented on code in PR #6411:
URL: https://github.com/apache/accumulo/pull/6411#discussion_r3360102880
##########
server/base/src/main/java/org/apache/accumulo/server/util/ZooKeeperMain.java:
##########
@@ -56,7 +56,7 @@ public UsageGroup usageGroup() {
@Override
public String description() {
- return "Starts Apache Zookeeper instance";
+ return "Starts an Apache Zookeeper client rooted at the current instance.";
Review Comment:
```suggestion
return "Starts an Apache ZooKeeper client rooted at the current
instance";
```
##########
shell/src/main/java/org/apache/accumulo/shell/commands/GetSplitsCommand.java:
##########
@@ -139,8 +139,8 @@ public Options getOptions() {
outputFileOpt = new Option("o", "output", true, "local file to write the
splits to");
outputFileOpt.setArgName("file");
- maxSplitsOpt =
- new Option("m", "max", true, "maximum number of splits to return
(evenly spaced)");
+ maxSplitsOpt = new Option("m", "max", true, "maximum number of splits to
return that are "
+ + "\"evenly\" selected from the existing splits based upon the
algorithm implemented in TableOperations.listSplits");
Review Comment:
I don't know if these are evenly split. That's not in the API javadoc, and
the implementation could change. I think it might be sufficient to say "maximum
number of splits to return; see TableOperations.listSplits"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
