DomGarguilo commented on code in PR #309:
URL: https://github.com/apache/accumulo-testing/pull/309#discussion_r3381614959


##########
pom.xml:
##########
@@ -121,19 +120,32 @@
       <scope>test</scope>
     </dependency>
   </dependencies>
+  <repositories>
+    <repository>
+      <releases>
+        <enabled>false</enabled>
+      </releases>
+      <snapshots>
+        <enabled>true</enabled>
+      </snapshots>
+      <id>apache.snapshots</id>
+      <name>Apache Snapshot Repository</name>
+      <url>https://repository.apache.org/content/repositories/snapshots</url>
+    </repository>
+  </repositories>

Review Comment:
   I have opted to leave this block in as opposed to adding 
`-Dapache.snapshots` to the github actions maven command(s).
   
   This block is necessary to pull from the snapshots repo. On a fresh install 
of accumulo-testing, its possible that the user does not have the current 
accumulo snapshot already in their `.m2`. Adding this repository block to the 
pom makes things more self contained and makes things work regardless of the 
state of the machine that is running things. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to