ctubbsii opened a new pull request, #6423: URL: https://github.com/apache/accumulo/pull/6423
* Use Client instead of Iface where it makes sense * Remove improperly thrown exceptions from RPC implementation methods (TException when specified directly, and any others that are not declared in the IDL for that method) * Add some essential exceptions to Thrift IDL where they were previously missed (and assumed to work) * Create an integration test that inspects our thrift service implementations and verifies we haven't introduced additional mistakes * Update JUnit and EasyMock to work better with Eclipse IDE on newer Java versions * Add some missing descriptions to some ThriftTableOperationException instances * Remove improper constructions of TApplicationException (should only be constructed internally inside libthrift, never by us, as it is an exception that signals to a client that a server-side exception occurred, most often by a runtime exception being thrown on the server side) * Construct ThriftSecurityOperation directly in RPC handler code, instead of constructing as AccumuloSecurityException and then calling .asThriftException(); that method is provided to make it easy to serialize public API exceptions for RPC requests, and is not needed in RPC code itself * Remove some attempts to convert RuntimeExceptions to TException in RPC handling code This fixes #6061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
