DomGarguilo commented on code in PR #6426:
URL: https://github.com/apache/accumulo/pull/6426#discussion_r3404404198
##########
test/src/main/java/org/apache/accumulo/test/conf/ResourceGroupConfigIT.java:
##########
@@ -275,7 +275,9 @@ public void testDuplicateCreatesRemovals()
client.resourceGroupOperations().create(rgid); // creating again
succeeds doing nothing
client.resourceGroupOperations().remove(rgid);
rgs = client.resourceGroupOperations().list();
- assertEquals(1, rgs.size());
+ final Set<ResourceGroupId> finalRgs = rgs;
+
+ Wait.waitFor(() -> finalRgs.size() == 1);
Review Comment:
I think with the way things are now, `finalRgs` will not update within the
`Wait.waitFor` block. Probably need to move
`client.resourceGroupOperations().list()` into that block to pull fresh info on
each retry.
##########
test/src/main/java/org/apache/accumulo/test/ListCompactionsIT.java:
##########
@@ -109,8 +110,10 @@ public void testListRunningCompactions() throws Exception {
new
ListCompactionsWrapper().getRunningCompactions(getCluster().getServerContext(),
true);
final Map<String,RunningCompactionSummary> compactionsByEcid = new
HashMap<>();
running.forEach(rcs -> compactionsByEcid.put(rcs.getEcid(), rcs));
+ final Map<String,
org.apache.accumulo.core.compaction.thrift.TExternalCompaction> finalExpected =
expected;
+
+ Wait.waitFor(() -> finalExpected.size() == compactionsByEcid.size());
Review Comment:
Same thing here. Need to update the collection within the looping wait block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
