ddanielr commented on code in PR #6437:
URL: https://github.com/apache/accumulo/pull/6437#discussion_r3438714586
##########
core/src/main/java/org/apache/accumulo/core/util/Merge.java:
##########
@@ -112,11 +116,18 @@ public void start(String[] args) throws MergeException {
if (opts.goalSize == null || opts.goalSize < 1) {
AccumuloConfiguration tableConfig =
new
ConfigurationCopy(client.tableOperations().getConfiguration(opts.tableName));
- opts.goalSize =
tableConfig.getAsBytes(Property.TABLE_SPLIT_THRESHOLD);
+ long newGoalSize =
tableConfig.getAsBytes(Property.TABLE_SPLIT_THRESHOLD);
+ message("Invalid goal size: " + opts.goalSize + " Using the "
+ + Property.TABLE_SPLIT_THRESHOLD.getKey() + " value of : " +
newGoalSize);
+ opts.goalSize = newGoalSize;
Review Comment:
Yes I agree that a size of 0 should be a valid value, but I thought that
would be a large behavior change in a patch release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
