ddanielr commented on code in PR #6449:
URL: https://github.com/apache/accumulo/pull/6449#discussion_r3493140669
##########
server/base/src/main/java/org/apache/accumulo/server/metadata/ServerAmpleImpl.java:
##########
@@ -270,7 +270,8 @@ public Iterator<GcCandidate> getGcCandidates(DataLevel
level) {
throw new RuntimeException(e);
}
scanner.setRange(range);
- return scanner.stream().filter(entry ->
entry.getValue().equals(SkewedKeyValue.NAME))
+ scanner.addScanIterator(new IteratorSetting(25, "gcCandidate",
GcCandidateFilter.class));
Review Comment:
Are we keeping track of the system iterator priorities being used?
I see the default value of the versioning iterator being set at 20, but
that's just a hardcoded value.
https://github.com/apache/accumulo/blob/9d1377c75641f135259294255f9411b1f481f99c/core/src/main/java/org/apache/accumulo/core/iteratorsImpl/IteratorConfigUtil.java#L110-L111
Wondering if that initial value of `20` should be refactored into a system
constant of `DEFAULT_ITERATOR_PRIORITY`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
