dlmarion commented on PR #6455: URL: https://github.com/apache/accumulo/pull/6455#issuecomment-4846813408
Here's a good example of the impact of this change. https://github.com/apache/accumulo/blob/1234b637049ea69d3d9b3086fdff1a3a273b2763/core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchReaderIterator.java#L957-L960 The current version of `Key(TKey)` looks like: https://github.com/apache/accumulo/blob/1234b637049ea69d3d9b3086fdff1a3a273b2763/core/src/main/java/org/apache/accumulo/core/data/Key.java#L687-L707 The same code prior to #6430 looks like: https://github.com/apache/accumulo/blob/1852dbfe9c944bcda6ee84cc3db911be86ade00c/core/src/main/java/org/apache/accumulo/core/data/Key.java#L688-L707 The calls to `bufferForX` create a copy of the ByteBuffer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
