ctubbsii commented on code in PR #6454: URL: https://github.com/apache/accumulo/pull/6454#discussion_r3502330015
########## server/base/src/main/java/org/apache/accumulo/server/rpc/CustomThreadedSelectorServer.java: ########## @@ -1,74 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * https://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ -package org.apache.accumulo.server.rpc; - -import java.lang.reflect.Field; -import java.net.Socket; - -import org.apache.thrift.server.TThreadedSelectorServer; -import org.apache.thrift.transport.TNonblockingSocket; -import org.apache.thrift.transport.TNonblockingTransport; -import org.slf4j.LoggerFactory; - -public class CustomThreadedSelectorServer extends TThreadedSelectorServer { - - private final Field fbTansportField; - - public CustomThreadedSelectorServer(Args args) { - super(args); - - try { - fbTansportField = FrameBuffer.class.getDeclaredField("trans_"); - fbTansportField.setAccessible(true); - } catch (SecurityException | NoSuchFieldException e) { - throw new IllegalStateException("Failed to access required field in Thrift code.", e); - } - } - - private TNonblockingTransport getTransport(FrameBuffer frameBuffer) { - try { - return (TNonblockingTransport) fbTansportField.get(frameBuffer); - } catch (IllegalAccessException e) { - throw new IllegalStateException(e); - } - } - - @Override - protected Runnable getRunnable(FrameBuffer frameBuffer) { - return () -> { - - try { - TNonblockingTransport transport = getTransport(frameBuffer); - - if (transport instanceof TNonblockingSocket tsock) { - // This block of code makes the client address available to the server side code that - // executes a RPC. It is made available for informational purposes. - Socket sock = tsock.getSocketChannel().socket(); - TServerUtils.clientAddress - .set(sock.getInetAddress().getHostAddress() + ":" + sock.getPort()); Review Comment: I believe all of this custom stuff is just to extract this client address from the socket, so we can use it elsewhere (probably for logging). I don't think we can delete this without replacing it with a different mechanism to get the client address. The field we are using reflection to read used to be accessible in previous versions of Thrift, and then it was made private, which caused us to make this class to work around that. We may still need this workaround, unless Thrift provided another means to obtain the client address from the connection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
