dlmarion commented on PR #6457: URL: https://github.com/apache/accumulo/pull/6457#issuecomment-4859259207
So, these changes look good, but there is still an issue. Take this code for example: https://github.com/apache/accumulo/blob/618addfdec6c3e8fc61af6489046c4ef74c33b06/core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftScanner.java#L970-L972 The code before #6430 looked like: https://github.com/apache/accumulo/blob/5f1628245eeafe99ed3c7a19a0b72a739e80fb7b/core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftScanner.java#L967-L969 The code in #6430 made the members private, so when accessing `TKeyValue.value` the calling code had to call either `TKeyValue.getValue()` or `TKeyValue.bufferForValue()` as below. https://github.com/apache/accumulo/blob/618addfdec6c3e8fc61af6489046c4ef74c33b06/core/src/main/thrift-gen-java/org/apache/accumulo/core/dataImpl/thrift/TKeyValue.java#L177-L184 The changes in this PR only removes the defensive copy from `bufferForValue`, so the calling code needs to change as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
