dlmarion commented on code in PR #6463:
URL: https://github.com/apache/accumulo/pull/6463#discussion_r3551491221
##########
core/src/main/java/org/apache/accumulo/core/data/ConditionalMutation.java:
##########
@@ -60,7 +60,6 @@ public ConditionalMutation(CharSequence row, Condition...
conditions) {
}
public ConditionalMutation(ByteSequence row, Condition... conditions) {
- // TODO add ByteSequence methods to mutations
super(row.toArray());
Review Comment:
I'm assuming the new constructor would be called here too. I'm curious how
many places in the code would take advantage of the new constructor for the
amount of code that it adds to Mutation. If there are not many places, then I
think it might be better to just remove the TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
