ctubbsii commented on code in PR #6435:
URL: https://github.com/apache/accumulo/pull/6435#discussion_r3554999414
##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader11to12.java:
##########
@@ -988,4 +1004,108 @@ void moveTableProperties(ServerContext context) {
LOG.info(
"Moving table properties from system configuration to namespace
configurations complete.");
}
+
+ @VisibleForTesting
+ public void deleteCompactionTempFiles(final ServerContext ctx, final
DeleteStats stats,
+ final Collection<Path> deletedFiles) {
+
+ final String pattern = "/tables/*/*/*";
Review Comment:
This pattern is very broad, and then later, paths are filtered to only
collect `.rf_tmp`. Wouldn't it make more sense to include this as part of the
glob pattern, as in:
```suggestion
final String pattern = "/tables/*/*/*.rf_tmp";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
