ctubbsii commented on code in PR #138:
URL: https://github.com/apache/accumulo-examples/pull/138#discussion_r3562525805
##########
spark/README.md:
##########
@@ -36,9 +36,10 @@ a Spark application that does following:
bulk import to Accumulo table
2. **Batchwriter** - Creates a `BatchWriter` in Spark code to write to the
table.
-This application can be run using the command:
+This application can be run using the following commands:
- ./run.sh batch /path/to/accumulo-client.properties
+ $ cd /path/to/accumulo-examples/spark
+ $ ./run.sh batch /path/to/accumulo-client.properties
Review Comment:
This README is already in the directory, so the `cd` is implied. This part
doesn't really need to change, does it?
##########
docs/reservations.md:
##########
@@ -25,14 +25,14 @@ and trent to reserve room06 on 20140101. Bob ends up
getting the reservation
and everyone else is put on a wait list. The example code will take any string
for what, when and who.
- $ /path/to/accumulo org.apache.accumulo.server.util.ListInstances
+ $ accumulo inst list-instances
Instance Name | Instance ID | Master
---------------------+--------------------------------------+-------------------------------
<instance name> | 9f8f2a97-432f-4e66-b153-861e2a1ca246 |
localhost:9999
- $ /path/to/accumulo shell -u root -p secret -e "createnamespace examples"
- $ /path/to/accumulo shell -u root -p secret -e "createtable examples.ars"
+ $ accumulo shell --user root --password secret --execute-command
"createnamespace examples"
+ $ accumulo shell --user root --password secret --execute-command
"createtable examples.ars"
Review Comment:
We can drop the user and password options, as the user can specify these in
a client config file, and that's not what this example is trying to teach, so
it's fine to omit them. I would not expand the execute-command, as it's much
more common for people to use the single letter version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
