ctubbsii commented on code in PR #6402:
URL: https://github.com/apache/accumulo/pull/6402#discussion_r3562736310
##########
core/src/main/java/org/apache/accumulo/core/iterators/user/VisibilityFilter.java:
##########
@@ -136,14 +157,25 @@ public IteratorOptions describeOptions() {
io.addNamedOption(FILTER_INVALID_ONLY,
"if 'true', the iterator is instructed to ignore the authorizations
and"
+ " only filter invalid visibility labels (default: false)");
- io.addNamedOption(AUTHS,
- "the serialized set of authorizations to filter against (default:
empty"
- + " string, accepts only entries visible by all)");
+ io.addNamedOption(NUM_AUTHS,
+ "The number of serialized authorizations to filter against (default
0)");
+ io.addUnnamedOption(AUTH_PREFIX
+ + "N, where the value is a serialized set of authorizations. N must be
between zero and NUM_AUTHS.");
Review Comment:
My suggestion was about concatenating the serialized forms, which don't
contain semi-colons. I had forgotten that we still had code in there that read
the old format. I like how you ended up using the header in the serialized form
as the delimiter. I guess the semi-colon wasn't needed. In any case, you
basically ended up with what I was thinking: a concatenated form of the
serialized sets. :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
