phrocker commented on code in PR #6476:
URL: https://github.com/apache/accumulo/pull/6476#discussion_r3597263160
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/namespace/delete/DeleteNamespace.java:
##########
@@ -48,7 +50,12 @@ public long isReady(FateId fateId, FateEnv environment)
throws Exception {
}
@Override
- public Repo<FateEnv> call(FateId fateId, FateEnv environment) {
+ public Repo<FateEnv> call(FateId fateId, FateEnv environment) throws
Exception {
+ if
(!environment.getContext().getTableMapping(namespaceId).getIdToNameMap().isEmpty())
{
Review Comment:
I could be wrong, but zk will only guarantee the watch event is queued
before a subsequent op response, not that the cache has applied it. The window
is small I think. Should we do the emptiness check inside a mutateExisting on
the mapping node the way we do in TableMapping.put/remove ? that gets you cas
rather than read then act?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
