Amemeda commented on code in PR #6487:
URL: https://github.com/apache/accumulo/pull/6487#discussion_r3624535751
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -1564,6 +1564,23 @@ public Property replacedBy() {
return replacedBy;
}
+ /**
+ * Gets the defined required properties
+ *
+ * @return Set<Property>
+ */
+ public static Set<Property> getRequiredProperties() {
+ return Set.of(Property.INSTANCE_ZK_HOST, Property.INSTANCE_ZK_TIMEOUT,
+ Property.INSTANCE_SECRET, Property.INSTANCE_VOLUMES,
Property.GENERAL_THREADPOOL_SIZE,
+ Property.GENERAL_DELEGATION_TOKEN_LIFETIME,
+ Property.GENERAL_DELEGATION_TOKEN_UPDATE_INTERVAL,
Property.GENERAL_IDLE_PROCESS_INTERVAL,
+ Property.GENERAL_LOW_MEM_DETECTOR_INTERVAL,
Property.GENERAL_LOW_MEM_DETECTOR_THRESHOLD,
+ Property.GENERAL_SERVER_LOCK_VERIFICATION_INTERVAL,
Property.MANAGER_CLIENTPORT,
+ Property.TSERV_CLIENTPORT, Property.GC_CYCLE_START,
Property.GC_CYCLE_DELAY,
+ Property.GC_PORT, Property.MONITOR_PORT,
Property.TABLE_MAJC_RATIO,
+ Property.TABLE_SPLIT_THRESHOLD);
+ }
Review Comment:
Are there any more required properties missing? Or how can I tell if the
property is required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
